llvm: Match aarch64 data layout to new LLVM layout #131760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rustbot +llvm-main |
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. |
|
@rustbot label: +llvm-main |
rustbot
added
the
llvm-main
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
maurer
force-pushed
the
data-layout-aarch64
branch
from
639f5ea to
0a20e4c
Compare
|
Integration test failed on the initial patch - it looks like I missed a few aarch64/arm64es that had slightly different targets. |
maurer
force-pushed
the
data-layout-aarch64
branch
from
0a20e4c to
40eccb1
Compare
cuviper
added
S-waiting-on-review
LLVM has added 3 new address spaces to support special Windows use cases. These shouldn't trouble us for now, but LLVM requires matching data layouts. See llvm/llvm-project#111879 for details
maurer
force-pushed
the
data-layout-aarch64
branch
from
40eccb1 to
e985396
Compare
|
This has now cleared integration tests and they've gone green again. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2024
Rollup of 10 pull requests Successful merges: - rust-lang#131582 (Add wasm32-unknown-emscripten platform support document) - rust-lang#131694 (Make fuchsia-test-runner.py compatible with new JSON output from llvm-readelf) - rust-lang#131700 (Fix match_same_arms in stable_mir) - rust-lang#131712 (Mark the unstable LazyCell::into_inner const) - rust-lang#131746 (Relax a memory order in `once_box`) - rust-lang#131754 (Don't report bivariance error when nesting a struct with field errors into another struct) - rust-lang#131760 (llvm: Match aarch64 data layout to new LLVM layout) - rust-lang#131764 (Fix unnecessary nesting in run-make test output directories) - rust-lang#131766 (Add mailmap entry for my dev-desktop setup) - rust-lang#131771 (Handle gracefully true/false in `cfg(target(..))` compact) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2024
Rollup merge of rust-lang#131760 - maurer:data-layout-aarch64, r=nikic llvm: Match aarch64 data layout to new LLVM layout LLVM has added 3 new address spaces to support special Windows use cases. These shouldn't trouble us for now, but LLVM requires matching data layouts. See llvm/llvm-project#111879 for details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM has added 3 new address spaces to support special Windows use cases. These shouldn't trouble us for now, but LLVM requires matching data layouts.
See llvm/llvm-project#111879 for details